-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: add new page size option #56112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Feature
New feature to highlight in changelogs.
[Feature] Data Views
Work surrounding upgrading and evolving views in the site editor and beyond
labels
Nov 14, 2023
oandregal
requested review from
youknowriad,
jorgefilipecosta and
ntsekouras
November 14, 2023 11:10
Size Change: +3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 14, 2023
oandregal
added
[Type] Enhancement
A suggestion for improvement.
[Type] Experimental
Experimental feature or API.
and removed
[Type] Feature
New feature to highlight in changelogs.
[Type] Enhancement
A suggestion for improvement.
labels
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Data Views
Work surrounding upgrading and evolving views in the site editor and beyond
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
What?
Adds a new page size option:
10
.Why?
It's smaller than the default
20
, it helps in some use cases (inspecting a smaller set of items, etc.), and it works well across all layouts (table, grid, side-by-side).How?
Add the new option to the list of options available.
Testing Instructions
20
is the default but you can switch to 10.